Merge branch 'json-fixes' into 'develop'

fix for bad nodeinfo

See merge request diasporg/Poduptime!253

CHANGELOG.md

@@ -17,6 +17,7 @@ The format is based on [Keep a Changelog] and this project adheres to [Semantic
 ### Deprecated
 ### Removed
 ### Fixed
+- nodeinfo that does not follow the spec will lower score
 ### Security
 
 ## [2.6.3]

db/update.php

@@ -146,11 +146,15 @@ foreach ($pods as $pod) {
     $jsonssl = json_decode($outputssl ?: '');
 
     if ($jsonssl !== null) {
-        $version               = $jsonssl->software->version ?? 0;
+        $version               = $jsonssl->software->version ?? '999.999.999';
+        if ($version == '999.999.999') {
+            //if nodeinfo has no version info then mark invalid
+            $score     -= 2;
+        }
         preg_match_all('((?:\d(.|-)?)+(\.)\d+\.*)', $version, $sversion);
         $shortversion          = $sversion[0][0] ?? '0.0.0.0';
         $signup                = ($jsonssl->openRegistrations ?? false) === true;
-        $softwarename          = strtolower($jsonssl->software->name) ?? 'unknown';
+        $softwarename          = $jsonssl->software->name ? strtolower($jsonssl->software->name) : 'unknown';
         $name                  = $jsonssl->metadata->nodeName ?? $softwarename;
         //dirty hack for badnodeinfo, this complains a lot, not a good fix.
         $total_users           = isset($jsonssl->usage->users->total) ? $jsonssl->usage->users->total : 0;