Unverified Commit 1e827161 authored by Jonne Haß's avatar Jonne Haß Committed by Benjamin Neff

rubocop: increase complexity limits [ci skip]

parent 17af65e2
...@@ -18,7 +18,7 @@ Metrics/LineLength: ...@@ -18,7 +18,7 @@ Metrics/LineLength:
# Too short methods lead to extraction of single-use methods, which can make # Too short methods lead to extraction of single-use methods, which can make
# the code easier to read (by naming things), but can also clutter the class # the code easier to read (by naming things), but can also clutter the class
Metrics/MethodLength: Metrics/MethodLength:
Max: 20 Max: 20
# The guiding principle of classes is SRP, SRP can't be accurately measured by LoC # The guiding principle of classes is SRP, SRP can't be accurately measured by LoC
...@@ -26,11 +26,17 @@ Metrics/ClassLength: ...@@ -26,11 +26,17 @@ Metrics/ClassLength:
Max: 1500 Max: 1500
Metrics/ModuleLength: Metrics/ModuleLength:
Max: 1500 Max: 1500
# Raise AbcSize from 15 to 20 # Raise complexity metrics
Metrics/AbcSize: Metrics/AbcSize:
Max: 20 Max: 20
Metrics/CyclomaticComplexity:
Max: 20
Metrics/PerceivedComplexity:
Max: 20
# Some blocks are longer. # Some blocks are longer.
Metrics/BlockLength: Metrics/BlockLength:
ExcludedMethods: ExcludedMethods:
...@@ -88,7 +94,7 @@ Lint/AssignmentInCondition: ...@@ -88,7 +94,7 @@ Lint/AssignmentInCondition:
AllowSafeAssignment: false AllowSafeAssignment: false
# A specialized exception class will take one or more arguments and construct the message from it. # A specialized exception class will take one or more arguments and construct the message from it.
# So both variants make sense. # So both variants make sense.
Style/RaiseArgs: Style/RaiseArgs:
Enabled: false Enabled: false
...@@ -151,11 +157,11 @@ Lint/ShadowingOuterLocalVariable: ...@@ -151,11 +157,11 @@ Lint/ShadowingOuterLocalVariable:
# Check with yard instead. # Check with yard instead.
Style/Documentation: Style/Documentation:
Enabled: false Enabled: false
# This is just silly. Calling the argument `other` in all cases makes no sense. # This is just silly. Calling the argument `other` in all cases makes no sense.
Naming/BinaryOperatorParameterName: Naming/BinaryOperatorParameterName:
Enabled: false Enabled: false
# There are valid cases, for example debugging Cucumber steps, # There are valid cases, for example debugging Cucumber steps,
# also they'll fail CI anyway # also they'll fail CI anyway
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment