Some simplifications (#72)

* Simplify arithmetics for $score.
Use PHP7 random_int method for improved random int generation.

* Simplify uptimerobot API calls by removing JSON callback.

* Simplify user and admin ratings.

* Smaller fixes and command simplifications.

cleanup.php

@@ -51,7 +51,7 @@ $numrows = pg_num_rows($result);
       $row['score']
     );
 
-    echo '<tr><td><a class="text-success" target="_self" href="https://' $row['domain'] . '">' . $row['domain'] . '<div title="' . $tip . '" class="tipsy" style="display: inline-block">?</div></a></td>';
+    echo '<tr><td><a class="text-success" target="_self" href="https://' . $row['domain'] . '">' . $row['domain'] . '<div title="' . $tip . '" class="tipsy" style="display: inline-block">?</div></a></td>';
 
     if (stristr($row['shortversion'], 'head')) {
       $version = '.dev';
@@ -79,7 +79,7 @@ $numrows = pg_num_rows($result);
     echo '<td>' . $row['active_users_monthly'] . '</td>';
     echo '<td>' . $row['local_posts'] . '</td>';
     echo '<td>' . $row['comment_counts'] . '</td>';
-    $moreurl = 'https://api.uptimerobot.com/getMonitors?format=json&customUptimeRatio=7-30-60-90&apiKey=' . $row['stats_apikey'];
+    $moreurl = 'https://api.uptimerobot.com/getMonitors?format=json&noJsonCallback=1&customUptimeRatio=7-30-60-90&apiKey=' . $row['stats_apikey'];
     echo '<td><div title="Last Check ' . $row['date_updated'] . '" class="tipsy"><a target="_self" href="' . $moreurl . '">' . $row['monthsmonitored'] . '</a></div></td>';
     echo '<td>' . $row['score'] . '</td>';
     echo '<td><div class="tipsy" title="' . $row['sslvalid'] . '">con info </td>';

db/add.php

@@ -71,7 +71,7 @@ if (stristr($outputssl, 'nodeName')) {
   $message = sprintf(
     "%1\$s\n\nStats Url: %2\$s\n\nPod: %3\$s\n\n",
     'https://' . $_SERVER['HTTP_HOST'],
-    'https://api.uptimerobot.com/getMonitors?format=json&customUptimeRatio=7-30-60-90&apiKey=' . $_url,
+    'https://api.uptimerobot.com/getMonitors?format=json&noJsonCallback=1&customUptimeRatio=7-30-60-90&apiKey=' . $_url,
     'https://' . $_SERVER['HTTP_HOST'] . '/db/pull.php?debug=1&domain=' . $_domain
   );
   $message .= 'Your pod will not show right away, needs to pass a few checks, Give it a few hours!';

showstats.php

@@ -17,18 +17,15 @@ $result || die('Error in SQL query: ' . pg_last_error());
 $apikey = pg_fetch_all($result);
 $upti   = curl_init();
 $key    = $apikey[0]['stats_apikey'];
-$data   = ['all_time_uptime_ratio' => 1, 'format' => 'json', 'custom_uptime_ratios' => '7-30-60-90', 'response_times' => 1, 'response_times_average' => 86400, 'api_key' => $key, 'callback' => 'jsonpUptimeRobot'];
+$data   = ['all_time_uptime_ratio' => 1, 'format' => 'json', 'custom_uptime_ratios' => '7-30-60-90', 'response_times' => 1, 'response_times_average' => 86400, 'api_key' => $key];
 curl_setopt($upti, CURLOPT_URL, 'https://api.uptimerobot.com/v2/getMonitors');
 curl_setopt($upti, CURLOPT_HEADER, 0);
 curl_setopt($upti, CURLOPT_POST, 1);
 curl_setopt($upti, CURLOPT_POSTFIELDS, http_build_query($data));
 curl_setopt($upti, CURLOPT_RETURNTRANSFER, 1);
 curl_setopt($upti, CURLOPT_CONNECTTIMEOUT, 8);
-$uptimerobot = curl_exec($upti);
+$uptr = json_decode(curl_exec($upti));
 curl_close($upti);
-$json_encap = 'jsonpUptimeRobot()';
-$up2        = substr($uptimerobot, strlen($json_encap) - 1, strlen($uptimerobot) - strlen($json_encap));
-$uptr       = json_decode($up2);
 echo '<b>UptimeRobot Json displayed in Human</b><br><br>';
 echo 'Name: ' . $uptr->monitors[0]->friendly_name . '<br>';
 echo 'Url: ' . $uptr->monitors[0]->url . '<br>';